Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha thank you for the PR,

I noticed that if I set for example:

apiVersion: controller.devfile.io/v1alpha1
config:
  workspace:
    containerResourceCaps:
      limits:
        cpu: '102'
        memory: 200Gi
      requests:
        cpu: '102'
        memory: 200Mi
kind: DevWorkspaceOperatorConfig
metadata:
  name: devworkspace-operator-config
  namespace: openshift-operators

And create a devworkspace with no cpu limits or requests:

apiVersion: workspace.devfile.io/v1alpha2
kind: DevWorkspace
metadata:
  name: devfile
  namespace: admin-devspaces
spec:
  started: true
  template:
    components:
      - container:
          image: 'quay.io/devfile/universal-developer-image:latest'
          memoryLimit: 5Gi
          memoryRequest: 3Gi
          sourceMapping: /projects
        name: tools-2

Then it looks like the cpu: 102 is being applied to the devworkspace:

'Error creating DevWorkspace deployment: Detected unrecoverable event FailedScheduling: 0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod.'

If I update the DWOC to set the cpu limit and request cap to 10, the devworkspace starts, and the container has a limit and request set to 10.

I think the cap should not be applied to the cpu in both cases?

@dkwon17
From my understanding limits must be applied since there were not defined ones in the devworkspace.

This feature request proposes an enhancement to Red Hat Dev Spaces that allows Dev Spaces 
administrators to configure the CheCluster to ignore resource requests and limits specified 
in devfiles. Instead, the cluster should enforce standardized resource values for 
all workspaces at the cluster level. 

@tolusha : I have a minor question about the precedence order of these fields. I see there is an older field defaultContainerResources for specifying default resource requirements, which seems intended to define default CPU/memory values when a DevWorkspace doesn’t specify any (and mentions that no CPU is added by default).:

I was under the impression that containerResourceCaps were meant to act as upper bounds when resource values are defined in the DevWorkspace, rather than being applied when no CPU requests/limits are set at all. When I saw the CPU value being applied even with no CPU specified in the DevWorkspace, it made me wonder if I’m interpreting this incorrectly.

Could you please review if these expectations are correct?

Hello, @rohanKanojia
The table is correct.

@tolusha, if a container does not specify limits / requests the maximums from DWOC will be used, right?
This is an important nuance that should be documented at the specification level, I believe.

@ibuziuk correct

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/retest